fix: should be closed when press esc after click portal #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
+ Coverage 97.86% 97.90% +0.04%
==========================================
Files 13 13
Lines 374 382 +8
Branches 106 108 +2
==========================================
+ Hits 366 374 +8
Misses 7 7
Partials 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zombieJ
approved these changes
Aug 1, 2023
yoyo837
reviewed
Aug 1, 2023
| return () => { | ||
| window.removeEventListener('keydown', onKeyDown); | ||
| }; | ||
| }, [visible]); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix ant-design/ant-design#43912
没点击 Portal 时，按下 esc 有效，因为是走的 rc-dialog 的 onClose（绑在 div 上），点击 Portal 后就无效了。于是给 Portal 单独绑定 esc